Skip to content

fix: default ignore paths for copy and render now explicitly match th…#186

Merged
j-d-carmichael merged 1 commit intomainfrom
fix/ignore-patterns
Jun 17, 2025
Merged

fix: default ignore paths for copy and render now explicitly match th…#186
j-d-carmichael merged 1 commit intomainfrom
fix/ignore-patterns

Conversation

@j-d-carmichael
Copy link
Copy Markdown
Contributor

fix: default ignore paths for copy and render now explicitly match the build & dist folder only, avoiding accidental matches with similarly named files (e.g., tsconfig.build.json).

context:

  • tsconfig.build.json in a tpl repository
  • run generate-it and the default regex which says if the current target file should or shouldn't be copied over says no

why:

  • it was matching for any path with build in it

fix:

  • alter the regex so as the match is on the folder, ie build/ not just build

…e build & dist folder only, avoiding accidental matches with similarly named files (e.g., tsconfig.build.json).
@j-d-carmichael j-d-carmichael requested a review from p-mcgowan June 16, 2025 10:28
@j-d-carmichael
Copy link
Copy Markdown
Contributor Author

@p-mcgowan this is a pretty simple fix - regex adjustment

Copy link
Copy Markdown
Contributor

@p-mcgowan p-mcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@j-d-carmichael j-d-carmichael merged commit fb7628f into main Jun 17, 2025
4 checks passed
@j-d-carmichael j-d-carmichael deleted the fix/ignore-patterns branch June 17, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants